[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I see this test failing on Linux right now (bots are down, so I can't confirm that the official bots fail as well). The failure is because of the last decorator which was not part of the review:

  @skipIf(macos_version=["<", "10.14"])

It looks like this only works correctly when mac_ver returns a meaningful result (a.k.a. on mac platforms), so linux is broken.

Another thing that I noticed is that the name of the test class (LibcxxOptionalDataFormatterTestCase) was re-used from another test. This has caused problems in the past with test overriding each other's results because they share the same class and test name (as these do).


https://reviews.llvm.org/D49271