[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

[Zachary Turner via Phabricator via lldb-commits]

zturner added a comment.

In https://reviews.llvm.org/D53086#1263001, @zturner wrote:

> In https://reviews.llvm.org/D53086#1261697, @aleksandr.urakov wrote:
>
> > Thanks a lot for so detailed answer, it helps!
> >
> > So we need to parse a FPO program and to convert it in a DWARF expression too. The problem here (in the DIA case) is that I don't know how to retrieve the required FPO range (we have a symbol context when creating a variable, but it seems that it doesn't contain enough information).
>
>
> I think the `SymbolContext` should have enough information.  As long as you can find the `PDBSymbolFunction` for the current frame, that gives you the range of the function, and the `IDiaSymbol` for the variable should give you the important info like register, offset, etc.


Do we have access to the current instruction pointer?  That's what you need to find the correct FPO record.


https://reviews.llvm.org/D53086