[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

[Vedant Kumar via Phabricator via lldb-commits]

vsk created this revision.
vsk added reviewers: stella.stamenova, zturner.

This allows bots which haven't updated to pass in --filecheck to dotest.py to run more tests. FileCheck-dependent tests will continue to fail.


https://reviews.llvm.org/D53175

Files:
  lldb/packages/Python/lldbsuite/test/dotest.py


Index: lldb/packages/Python/lldbsuite/test/dotest.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/dotest.py
+++ lldb/packages/Python/lldbsuite/test/dotest.py
@@ -311,8 +311,8 @@
         # The CMake build passes in a path to a working FileCheck binary.
         configuration.filecheck = os.path.abspath(args.filecheck)
     else:
-        logging.error('No valid FileCheck executable; aborting...')
-        sys.exit(-1)
+        logging.warning('No valid FileCheck executable; some tests may fail...')
+        logging.warning('(Pass in a --filecheck argument to dotest.py)')
 
     if args.channels:
         lldbtest_config.channels = args.channels


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53175.169317.patch
Type: text/x-patch
Size: 716 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181011/4f10120f/attachment.bin>