[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

[Zachary Turner via lldb-commits]

On Wed, Oct 10, 2018 at 6:38 PM Hui Huang via Phabricator <
reviews at reviews.llvm.org> wrote:

> Hui added inline comments.
>
>
> ================
> Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:810
> +
> +  std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
> +
> ----------------
> zturner wrote:
> > Does this actually need to be a `recursive_mutex`?
> I think there is access to the member 'm_filespec_

ap'.


I mean instead of a non recursive mutex.

>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181010/ed4b86bd/attachment.html>