[Lldb-commits] [PATCH] D52851: Adding support to step into the callable wrapped by libc++ std::function

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

Couple more lines you can delete from the test case, and I think you should make this a debug-variant insensitive test.  Do that and this is good.



================
Comment at: packages/Python/lldbsuite/test/lang/cpp/std-function-step-into-callable/TestStdFunctionStepIntoCallable.py:29-30
+        self.build()
+        self.runCmd("file " + self.getBuildArtifact("a.out"), CURRENT_EXECUTABLE_SET)
+
+        exe = self.getBuildArtifact("a.out")
----------------
You don't need these two lines anymore.  You never use the exe variable, and the target you make with this "file" command is never used (you correctly use the one returned by run_to_source_breakpoint.)

Also, this doesn't seem like a debug variant sensitive test, so you really should make this a NO_DEBUG_INFO test.  We're trying to do that wherever it makes sense just to keep down the number of tests we run.


https://reviews.llvm.org/D52851