[Lldb-commits] [PATCH] D51874: Fix buildbot regression by rL339929: NameError: global name 'test_directory' is not defined

Vedant Kumar via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 3 14:29:59 PDT 2018


vsk added inline comments.


================
Comment at: packages/Python/lldbsuite/test/dosep.py:1693
     for core in cores:
         dst = core.replace(test_directory, "")[1:]
         dst = dst.replace(os.path.sep, "-")
----------------
Instead of redefining test_directory, please use 'test_subdir' in the call to core.replace. That leaves the logic to find the right path in configuration.get_absolute_path_to_root_test_dir.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D51874





More information about the lldb-commits mailing list