[Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In https://reviews.llvm.org/D52618#1250909, @zturner wrote:

> One idea would be to define some lit substitutions like %debuginfo. It’s
>  true you can produce a gcc style command line that will be equivalent to a
>  clang-cl invocation but it won’t be easy. eg you’ll needing to pass
>  -fms-compatibility as well as various -I for includes.
>
> It may be easier to have substitutions instead


Using substitutions SGTM.

I am not sure if this is a good idea, but it had occured to me that we could put `-fms-compatibility` and friends into a substitution of it's own, which would be computed by lit (through some equivalent of `clang++ -###` ?). That way, the tests could still use g++ syntax, only the command lines would contain an extra `%cflags` argument. This has the advantage of extra flexibility over a predefined set of compile commands (%compile_with_debug, %compile_without_debug, ...), and it might be sufficient to make cross-compiling work, if we ever need it.


https://reviews.llvm.org/D52618