[Lldb-commits] [PATCH] D52651: Add functionality to export settings

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere updated this revision to Diff 167889.
JDevlieghere added a comment.

Thanks a lot for the feedback! I clearly overlooked some stuff when inspiring myself on the other CommandObject code.

I've updated the diff:

- Rename functionality to read and write for consistency with breakpoints.
- Add `settings read` instead of having to source the exported file.
- Deal with zero or multiple arguments. (This is now valid input)
- Fix completion for file path.
- Go through FileSpec to ensure `~` is expanded.
- Add more tests.


https://reviews.llvm.org/D52651

Files:
  include/lldb/Interpreter/OptionValue.h
  lit/Settings/TestExport.test
  source/Commands/CommandObjectSettings.cpp
  source/Interpreter/OptionValueArray.cpp
  source/Interpreter/OptionValueDictionary.cpp
  source/Interpreter/OptionValueFileSpecLIst.cpp
  source/Interpreter/OptionValueFormatEntity.cpp
  source/Interpreter/OptionValueLanguage.cpp
  source/Interpreter/Property.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52651.167889.patch
Type: text/x-patch
Size: 16768 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181002/b65a5126/attachment-0001.bin>