[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 27 15:26:14 PDT 2018

aprantl added inline comments.

Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:22
+# Everything goes as .o files directly to the linker
dexonsmith wrote:
> aprantl wrote:
> > same here, just remove it
> I haven't read the full patch to see if this is relevant, but my maybe-out-of-date-Makefile-fu says this is not no-op.  It defines `C_SOURCES` as a variable, as opposed to a function-like macro (which would be `C_SOURCES =`, no colon).  IIRC, with the former, any changes to `C_SOURCES` (like `C_SOURCES += ...`) are evaluated immediately when it's a variable, lazily (on use) when it's a macro.  Usually the behaviour you want is a variable.
What Duncan says is correct. For this particular Makefile though, that difference shouldn't matter and it would be better to keep the file short and simple.


More information about the lldb-commits mailing list