[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

Stefan Gränitz via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 27 10:48:16 PDT 2018

sgraenitz added inline comments.

Comment at: source/Symbol/Symtab.cpp:520
+  return false;
clayborg wrote:
> This function is still pretty specific. Any comments on my above inlined comment?
Yes absolutely, but the same holds for most functions around here. This one is just a stripped-down version of the above `AppendSymbolIndexesWithTypeAndFlagsValue()`. Both of them are used exactly once (in `CalculateAbilities()` and `InitOSO()` respectively).

Of course this is all overly specific. Instead it should be `HasSymbol(Predicate)` and `AppendSymbol(Predicate, Collection&)`, but I don't think we gain anything here by making one of them generic.

My fix is very loosely connected to Symtab at all. IMHO it's preferable to keep the existing practice here. This code should be improved consistently in a refactoring commit with no semantic changes.


More information about the lldb-commits mailing list