[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 27 09:24:42 PDT 2018

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Just a few fixes. Looking good.

Comment at: include/lldb/lldb-enumerations.h:643-660
+  eSectionTypeDWARFDebugAbbrevDwo,
+  eSectionTypeDWARFDebugInfoDwo,
Add all of these to the end of this enum for API stability since this is a public header used in the API. If an older binary runs against a newer liblldb.so, all of these enums will be off.

Comment at: source/Symbol/ObjectFile.cpp:347
           case eSectionTypeDWARFDebugAbbrev:
+          case eSectionTypeDWARFDebugAbbrevDwo:
           case eSectionTypeDWARFDebugAddr:
Check for other ObjectFile subclasses that override this function. I believe ObjectFileMachO does.


More information about the lldb-commits mailing list