[Lldb-commits] [PATCH] D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 26 16:38:27 PDT 2018

You might be right, I’m on mobile so hard for me to review. I saw a bunch
of nullptr so assumed it was still using sentinel values for iterating. If
not, ignore my suggestion
On Wed, Sep 26, 2018 at 4:26 PM Tatyana Krasnukha via Phabricator <
reviews at reviews.llvm.org> wrote:

> tatyana-krasnukha added a comment.
> Hmm... There is no such logic left, isn't it?
> If you mean iterating OptionValueProperties::m_properties vector, I can
> replace cycles with range based for loop, but this doesn't seem to be
> related to these changes.
> Repository:
> https://reviews.llvm.org/D52572
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180926/828ddd68/attachment.html>

More information about the lldb-commits mailing list