[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

Vedant Kumar via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 26 12:27:43 PDT 2018

vsk added inline comments.

Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:1531
+  if (m_compile_unit_infos.size() > 1)
+    return 0;
sgraenitz wrote:
> sgraenitz wrote:
> > Skipping AddOSOARanges() here.
> > Could you leave an in-source comment explaining why this is commented out?
> @vsk AddOSOARanges() was commented out only temporarily. I reverted it in the latest patch and added these lines with a comment. Is that what you were asking for?
Ah sure sure, sorry, I missed the broader context of the change.


More information about the lldb-commits mailing list