[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

[Vedant Kumar via Phabricator via lldb-commits]

vsk added inline comments.


================
Comment at: lldb/source/Target/StackFrameList.cpp:331
+        dfs(next_callee);
+        if (ambiguous)
+          return;
----------------
aprantl wrote:
> On what path can this happen? Aren't all paths that set `ambiguous=true` returning immediately?
If a recursive call to dfs() sets `ambiguous = true` and returns early, we also want its caller to return early instead of visiting any additional edges. This is a small optimization: the code is correct without the early return.


https://reviews.llvm.org/D50478