[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 26 08:34:38 PDT 2018

aprantl added inline comments.

Comment at: lldb/source/Target/StackFrameList.cpp:331
+        dfs(next_callee);
+        if (ambiguous)
+          return;
On what path can this happen? Aren't all paths that set `ambiguous=true` returning immediately?

Comment at: lldb/source/Target/StackFrameList.cpp:404
+    callee->CalculateSymbolContext(&sc);
+    StackFrameSP synth_frame{new StackFrame(
+        m_thread.shared_from_this(), frame_idx, concrete_frame_idx, cfa,
`auto synth_frame = llvm::make_unique<StackFrame>(..)` ?


More information about the lldb-commits mailing list