[Lldb-commits] [PATCH] D52532: Pull GetSoftwareBreakpointPCOffset into base class

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: krytarowski, zturner.

This function encodes the knowledge of whether the PC points to the
breakpoint instruction of the one following it after the breakpoint is
"hit". This behavior mainly(*) depends on the architecture and not on the
OS, so it makes sense for it to be implemented in the base class, where
it can be shared between different implementations (Linux and NetBSD
atm).

(*) It is possible for an OS to expose a different API, perhaps by doing
some fixups in the kernel. In this case, the implementation can override
this function to implement custom behavior.


https://reviews.llvm.org/D52532

Files:
  include/lldb/Host/common/NativeProcessProtocol.h
  source/Host/common/NativeProcessProtocol.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.h
  source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52532.167064.patch
Type: text/x-patch
Size: 6388 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180926/de2ff2bf/attachment.bin>