[Lldb-commits] [PATCH] D51859: [NFC] Turn "load dependent files" boolean into an enum

[Brooks Davis via Phabricator via lldb-commits]

brooks added a comment.

Also broke the FreeBSD build:

  /usr/local/poudriere/ports/brooks/devel/llvm-devel/work/llvm-b418c2351b1fdf6faf6
  a2d010d804e895ef49932/tools/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.c
  pp:338:50: error: cannot initialize a parameter of type 'lldb_private::LoadDepen
  dentFiles' with an rvalue of type 'bool'
    GetTarget().SetExecutableModule(exe_module_sp, true);                        
                                                   ^~~~
  /usr/local/poudriere/ports/brooks/devel/llvm-devel/work/llvm-b418c2351b1fdf6faf6
  a2d010d804e895ef49932/tools/lldb/include/lldb/Target/Target.h:860:26: note: pass
  ing argument to parameter 'load_dependent_files' here
        LoadDependentFiles load_dependent_files = eLoadDependentsDefault);
                           ^
  /usr/local/poudriere/ports/brooks/devel/llvm-devel/work/llvm-b418c2351b1fdf6faf6
  a2d010d804e895ef49932/tools/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.c
  pp:522:50: error: cannot initialize a parameter of type 'lldb_private::LoadDepen
  dentFiles' with an rvalue of type 'bool'
        target->SetExecutableModule(exe_module_sp, true);
                                                   ^~~~
  /usr/local/poudriere/ports/brooks/devel/llvm-devel/work/llvm-b418c2351b1fdf6faf6
  a2d010d804e895ef49932/tools/lldb/include/lldb/Target/Target.h:860:26: note: pass
  ing argument to parameter 'load_dependent_files' here
        LoadDependentFiles load_dependent_files = eLoadDependentsDefault);
                           ^
  2 errors generated.
  ninja: build stopped: subcommand failed.


Repository:
  rL LLVM

https://reviews.llvm.org/D51859