[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 24 07:30:43 PDT 2018


clayborg added a comment.

So the main questions is: do we need a new section enum called eSectionTypeDWARFDebugInfoDWO? If so, then this patch changes. I think I would prefer adding a new enum.



================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:68
-    if (auto section_sp =
-            section_list->FindSectionByType(eSectionTypeDWARFDebugInfo, true))
-      if (!section_sp->GetName().GetStringRef().endswith("dwo"))
----------------
If dwo has a unique section name, just name a new enum for the .debug_info.dwo.


https://reviews.llvm.org/D52403





More information about the lldb-commits mailing list