[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

[George Rimar via Phabricator via lldb-commits]

grimar created this revision.
grimar added reviewers: LLDB, clayborg, aprantl, dblaikie, probinson.
Herald added a subscriber: JDevlieghere.

DWARF5 spec describes single file split dwarf case (when .dwo sections are in the .o files).

Problem is that LLDB does not work correctly in that case. The issue is that, for example, both .debug_info and .debug_info.dwo
has the same type: `eSectionTypeDWARFDebugInfo`. And when code searches section by type it might find the regular debug section
and not the .dwo one. It seems can be easily fixed though, patch shows the fix I am suggesting.

Note that currently, clang is unable to produce such output, the patch is on review atm: https://reviews.llvm.org/D52296.
It is still would be possible to use assembler to produce such files though.
But the test case refers to the flag from the review mentioned.


https://reviews.llvm.org/D52403

Files:
  include/lldb/Core/Section.h
  packages/Python/lldbsuite/test/functionalities/single-file-split-dwarf/TestSingleFileSplitDwarf.py
  packages/Python/lldbsuite/test/functionalities/single-file-split-dwarf/test.o.yaml
  packages/Python/lldbsuite/test/functionalities/single-file-split-dwarf/test.yaml
  source/Core/Section.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52403.166636.patch
Type: text/x-patch
Size: 16003 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180923/b6b7b451/attachment-0001.bin>