[Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

[Leonard Mosescu via lldb-commits]

Hi Greg, looking at request_evaluate() I noticed that it will evaluate the
string as a lldb command if prefixed by ` .

This is a great feature (it allows building REPL consoles on top of DAP),
but I'm curious how you picked up this convention? For example I believe
that the gdb DAP uses -exec 'command' instead.

On Thu, Aug 16, 2018 at 11:01 AM, Phabricator via Phabricator <
reviews at reviews.llvm.org> wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL339911: Add a new tool named "lldb-vscode"
> that implements the Visual Studio Code Debug… (authored by gclayton,
> committed by ).
> Herald added a subscriber: llvm-commits.
>
> Changed prior to commit:
>   https://reviews.llvm.org/D50365?vs=161058&id=161067#toc
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D50365
>
> Files:
>   lldb/trunk/lldb.xcodeproj/project.pbxproj
>   lldb/trunk/packages/Python/lldbsuite/test/dotest.py
>   lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/.categories
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/attach/Makefile
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/attach/TestVSCode_attach.py
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/attach/main.c
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/breakpoint/Makefile
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/breakpoint/TestVSCode_setBreakpoints.py
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/breakpoint/main.cpp
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/launch/Makefile
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/launch/TestVSCode_launch.py
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/launch/main.c
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/lldbvscode_testcase.py
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/stackTrace/Makefile
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/stackTrace/TestVSCode_stackTrace.py
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/stackTrace/main.c
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/step/Makefile
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/step/TestVSCode_step.py
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/step/main.cpp
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/variables/Makefile
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/variables/TestVSCode_variables.py
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-
> vscode/variables/main.cpp
>   lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
>   lldb/trunk/tools/CMakeLists.txt
>   lldb/trunk/tools/lldb-vscode/BreakpointBase.cpp
>   lldb/trunk/tools/lldb-vscode/BreakpointBase.h
>   lldb/trunk/tools/lldb-vscode/CMakeLists.txt
>   lldb/trunk/tools/lldb-vscode/ExceptionBreakpoint.cpp
>   lldb/trunk/tools/lldb-vscode/ExceptionBreakpoint.h
>   lldb/trunk/tools/lldb-vscode/FunctionBreakpoint.cpp
>   lldb/trunk/tools/lldb-vscode/FunctionBreakpoint.h
>   lldb/trunk/tools/lldb-vscode/JSONUtils.cpp
>   lldb/trunk/tools/lldb-vscode/JSONUtils.h
>   lldb/trunk/tools/lldb-vscode/LLDBUtils.cpp
>   lldb/trunk/tools/lldb-vscode/LLDBUtils.h
>   lldb/trunk/tools/lldb-vscode/README.md
>   lldb/trunk/tools/lldb-vscode/SourceBreakpoint.cpp
>   lldb/trunk/tools/lldb-vscode/SourceBreakpoint.h
>   lldb/trunk/tools/lldb-vscode/SourceReference.h
>   lldb/trunk/tools/lldb-vscode/VSCode.cpp
>   lldb/trunk/tools/lldb-vscode/VSCode.h
>   lldb/trunk/tools/lldb-vscode/VSCodeForward.h
>   lldb/trunk/tools/lldb-vscode/lldb-vscode-Info.plist
>   lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp
>   lldb/trunk/tools/lldb-vscode/package.json
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180920/1f6f78cc/attachment.html>