[Lldb-commits] [PATCH] D51859: [NFC] Turn "load dependent files" boolean into an enum

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.


================
Comment at: lldb/trunk/source/Target/Target.cpp:1449
     ObjectFile *executable_objfile = executable_sp->GetObjectFile();
+    bool load_dependens;
+    switch (load_dependent_files) {
----------------
I think it's a good idea to either initialize this to false or to add a default case in the switch statement. That way if the enum ever changes, the behavior will be strictly defined.


================
Comment at: lldb/trunk/source/Target/Target.cpp:1455
+    case eLoadDependentsYes:
+      load_dependens = true;
+      break;
----------------
Typo - I think you wanted this to be load_dependents


Repository:
  rL LLVM

https://reviews.llvm.org/D51859