[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

A typo and probably something copied from another test case, other than that this looks good.



================
Comment at: packages/Python/lldbsuite/test/functionalities/target_create_deps/TestTargetCreateDeps.py:2
+"""
+Test that breakpoint by symbol name works correctly with dynamic libs.
+"""
----------------
I don't  think this is what the test actually does...


================
Comment at: source/Commands/CommandObjectTarget.cpp:145
+    {eLoadDependentsDefault, "default",
+     "Only load dependents when the target is an executables."},
+    {eLoadDependentsNo, "true",
----------------
"executable" not "executables"


https://reviews.llvm.org/D51934