[Lldb-commits] [PATCH] D52247: Refactor FindVariable() core functionality into StackFrame out of SBFrame

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

I agree with Greg, this is the sort of function that we'd pass a ConstString to on the lldb_private side.

We haven't documented all the API's we should.  This one is pretty self-explanatory, but still we should try to document all the new functions we add, Davide's right there.

Other than those nits, this seems fine.


https://reviews.llvm.org/D52247