[Lldb-commits] [lldb] r342404 - Revert "[IRInterpreter] Minor cleanups, add comments. NFCI."
Davide Italiano via lldb-commits
lldb-commits at lists.llvm.org
Mon Sep 17 11:14:39 PDT 2018
Author: davide
Date: Mon Sep 17 11:14:38 2018
New Revision: 342404
URL: http://llvm.org/viewvc/llvm-project?rev=342404&view=rev
Log:
Revert "[IRInterpreter] Minor cleanups, add comments. NFCI."
This breaks buildbots.
Modified:
lldb/trunk/source/Expression/IRInterpreter.cpp
Modified: lldb/trunk/source/Expression/IRInterpreter.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRInterpreter.cpp?rev=342404&r1=342403&r2=342404&view=diff
==============================================================================
--- lldb/trunk/source/Expression/IRInterpreter.cpp (original)
+++ lldb/trunk/source/Expression/IRInterpreter.cpp Mon Sep 17 11:14:38 2018
@@ -601,13 +601,17 @@ bool IRInterpreter::CanInterpret(llvm::M
Value *operand = ii->getOperand(oi);
Type *operand_type = operand->getType();
- // Vectors are currently unsupported, give up.
- if (operand_type->getTypeID() == Type::VectorTyID)
+ switch (operand_type->getTypeID()) {
+ default:
+ break;
+ case Type::VectorTyID: {
if (log)
log->Printf("Unsupported operand type: %s",
PrintType(operand_type).c_str());
error.SetErrorString(unsupported_operand_error);
return false;
+ }
+ }
// The IR interpreter currently doesn't know about
// 128-bit integers. As they're not that frequent,
@@ -621,7 +625,7 @@ bool IRInterpreter::CanInterpret(llvm::M
return false;
}
- if (auto *constant = llvm::dyn_cast<Constant>(operand)) {
+ if (Constant *constant = llvm::dyn_cast<Constant>(operand)) {
if (!CanResolveConstant(constant)) {
if (log)
log->Printf("Unsupported constant: %s",
More information about the lldb-commits
mailing list