[Lldb-commits] [PATCH] D52065: WWW docs for scripted breakpoint resolvers

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: www/python-reference.html:325
+                <p>Another use of the Python API's in lldb is to create a custom breakpoint resolver.  This facility
+                  was added in r51967.  
+                </p>
----------------
Is that SVN revision high enough? Seems to be missing a digit?


================
Comment at: www/python-reference.html:334-335
+                <p>
+                  In lldb, a breakpoint is composed of three parts, the Searcher, and the Resolver, which cooperate to determine
+                  how breakpoint locations are set; and the the collection
+                  of options which determine what happens when a location triggers.  That last part includes the commands,
----------------
Feel free to ignore this suggestion, but maybe:

```
In lldb, a breakpoint is composed of three parts: the Searcher, the Resolver, and the Options. The Searcher and Resolver cooperate to determine how breakpoint locations are set and differ between each breakpoint type. Options determine what happens when a location triggers and includes the commands, conditions, ignore counts, etc. Options are common between all breakpoint types.
```


================
Comment at: www/python-reference.html:348
+                  The Searcher can be provided with a SearchFilter that it will use to restrict this search.  For instance, if the
+                  SearchFilter specifies a list of good Modules, the Searcher will not recurse into Modules that aren't on the list.
+                  When you pass the <b>-s modulename</b> flag to <b>break set</b> you are creating a Module-based search filter.
----------------
Remove good from above?
```
s/specifies a list of good Modules/specifies a list of Modules/
```


================
Comment at: www/python-reference.html:384
+                <p>
+                  At present, when adding a scripted Breakpoint type, you can only provide a custom Resolver, not a custom SearchFilter.
+                </p> 
----------------
```
At present, when adding a scripted Breakpoint type, you only need to provide a custom Resolver as the Searcher is handled automatically by LLDB using breakpoint options from the command line or SBTarget::BreakpointCreateXXX() function.
```
Is it the Resolvers job to provide the search depth? Or is this a Searcher option masquerading as Resolver callback?


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D52065