[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 14 10:12:35 PDT 2018

shafik added inline comments.

Comment at: source/Commands/CommandObjectTarget.cpp:153
+static OptionDefinition g_dependents_options[1] = {
+    {LLDB_OPT_SET_1, false, "no-dependents", 'd',
+     OptionParser::eOptionalArgument, nullptr, g_dependents_enumaration, 0,
Should "no-dependents" be "default"?

Comment at: source/Commands/CommandObjectTarget.cpp:181
+    const int short_option = g_dependents_options[option_idx].short_option;
+    switch (short_option) {
+    case 'd': {
Wouldn't an if/else make more sense here? I had to reread the description up top before this made sense that `option_value` is doing the work here.


More information about the lldb-commits mailing list