[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

[Greg Clayton via Phabricator via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Thanks for doing all requested changes! Looks great.



================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp:442
+        ReadDescriptors(debug_line_data, offset_ptr);
+    uint8_t dirCount = debug_line_data.GetU8(offset_ptr);
+    for (int i = 0; i < dirCount; ++i) {
----------------
grimar wrote:
> probinson wrote:
> > clayborg wrote:
> > > We might verify that this is indeed correct by looking at compiler sources. Seems weird to limit dirs to 255
> > The directory count is a ULEB not a ubyte.
> Oops. My mistake here, my initial version which used uleb128 was correct, but I looked at the wrong place too in the dwarf5 spec after that.
I incorrectly skimmed the DWARF 5 spec and looked at "directory_entry_format_count (ubyte)" and missed that this was for the directory entry format count... directories_count is indeed ULEB128.


https://reviews.llvm.org/D51935