[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

George Rimar via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 13 04:19:06 PDT 2018

grimar added inline comments.

Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp:442
+        ReadDescriptors(debug_line_data, offset_ptr);
+    uint8_t dirCount = debug_line_data.GetU8(offset_ptr);
+    for (int i = 0; i < dirCount; ++i) {
probinson wrote:
> clayborg wrote:
> > We might verify that this is indeed correct by looking at compiler sources. Seems weird to limit dirs to 255
> The directory count is a ULEB not a ubyte.
Oops. My mistake here, my initial version which used uleb128 was correct, but I looked at the wrong place too in the dwarf5 spec after that.


More information about the lldb-commits mailing list