[Lldb-commits] [PATCH] D51520: Add libc++ data formatter for std::variant

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik updated this revision to Diff 165201.
shafik marked 9 inline comments as done.
shafik added a comment.

Address comments on std::variant formatter

- Adding tests for reference to variant and variant of variant
- Refactoring test to be more efficient
- Refactoring unsafe code that assumed sizes of types between local machine and target machine were the same
  - Used to check to variant_npos which is max unsigned or -1


https://reviews.llvm.org/D51520

Files:
  lldb.xcodeproj/project.pbxproj
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/Makefile
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/main.cpp
  source/Plugins/Language/CPlusPlus/CMakeLists.txt
  source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  source/Plugins/Language/CPlusPlus/LibCxx.cpp
  source/Plugins/Language/CPlusPlus/LibCxx.h
  source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp
  source/Plugins/Language/CPlusPlus/LibCxxVariant.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51520.165201.patch
Type: text/x-patch
Size: 22468 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180913/53ae389d/attachment-0001.bin>