[Lldb-commits] [lldb] r342066 - Add compatibility version to liblldb in framework builds
Alex Langford via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 12 11:10:22 PDT 2018
Author: xiaobai
Date: Wed Sep 12 11:10:22 2018
New Revision: 342066
URL: http://llvm.org/viewvc/llvm-project?rev=342066&view=rev
Log:
Add compatibility version to liblldb in framework builds
Summary:
Building LLDB with xcodebuild sets the compatibility version of liblldb
in LLDB.framework. Building the framework with cmake does not set the
compatibility version, and so it defaults to 0.0.0. This is a discrepency in the
difference between the xcode build and the cmake build.
I tested this change by building without this patch. From the build tree I ran
`otool -L Library/Frameworks/LLDB.framework/Versions/A/LLDB` and got this:
```
@rpath/LLDB.framework/Versions/A/LLDB (compatibility version 0.0.0, current version 8.0.0)
```
Did the same with this patch and the output contained this:
```
@rpath/LLDB.framework/Versions/A/LLDB (compatibility version 1.0.0, current version 8.0.0)
```
Reviewers: clayborg, labath
Subscribers: mgorny, lldb-commits
Differential Revision: https://reviews.llvm.org/D51959
Modified:
lldb/trunk/source/API/CMakeLists.txt
Modified: lldb/trunk/source/API/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/CMakeLists.txt?rev=342066&r1=342065&r2=342066&view=diff
==============================================================================
--- lldb/trunk/source/API/CMakeLists.txt (original)
+++ lldb/trunk/source/API/CMakeLists.txt Wed Sep 12 11:10:22 2018
@@ -146,6 +146,7 @@ endif()
if (LLDB_BUILD_FRAMEWORK)
set_target_properties(liblldb
PROPERTIES
+ SOVERSION "1.0.0"
OUTPUT_NAME LLDB
FRAMEWORK On
FRAMEWORK_VERSION ${LLDB_FRAMEWORK_VERSION}
More information about the lldb-commits
mailing list