[Lldb-commits] [PATCH] D51966: Do not create new terminals when launching process on Windows by default

[Dávid Bolvanský via Phabricator via lldb-commits]

xbolva00 created this revision.
xbolva00 added reviewers: teemperor, zturner.
Herald added subscribers: lldb-commits, abidh.

Unify behaviour across platforms. (We create new terminals only on Windows).

process launch offers explicit option:

  -t ( --tty )
       Start the process in a terminal (not supported on all platforms).

So we should open new terminals if-t is used.

Fixes PR38222


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D51966

Files:
  source/Host/windows/ProcessLauncherWindows.cpp


Index: source/Host/windows/ProcessLauncherWindows.cpp
===================================================================
--- source/Host/windows/ProcessLauncherWindows.cpp
+++ source/Host/windows/ProcessLauncherWindows.cpp
@@ -72,7 +72,7 @@
     startupinfo.wShowWindow = SW_HIDE;
   }
 
-  DWORD flags = CREATE_NEW_CONSOLE | CREATE_UNICODE_ENVIRONMENT;
+  DWORD flags = CREATE_UNICODE_ENVIRONMENT;
   if (launch_info.GetFlags().Test(eLaunchFlagDebug))
     flags |= DEBUG_ONLY_THIS_PROCESS;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51966.165026.patch
Type: text/x-patch
Size: 495 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180912/494d3df2/attachment.bin>