[Lldb-commits] [PATCH] D51175: Add support for descriptions with command completions.

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 11 09:10:49 PDT 2018

JDevlieghere added a comment.

I don't know the completion API well enough to accept, but this looks like a nice improvement!

Comment at: source/Utility/CompletionRequest.cpp:79
+  // Add the completion if we haven't seen the same value before.
+  if (m_added_values.insert(r.GetUniqueKey()).second)
+    m_results.push_back(r);
Do you think there's any value in in checking the description? For example, if the description was empty for the existing value but a description is provided for the duplicate?



More information about the lldb-commits mailing list