[Lldb-commits] [PATCH] D51520: Add libc++ data formatter for std::variant

[Vedant Kumar via Phabricator via lldb-commits]

vsk added inline comments.


================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py:70
+        self.expect("frame variable v_no_value",
+                    substrs=['v_no_value =  No Value'])
----------------
Could you add a test which inspects a reference to a variant (to cover the "(( )?&)?" bit you're matching)?


================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/main.cpp:29
+    std::variant<int, double, char> v3;
+    std::variant<int, double, char> v_no_value;
+
----------------
Does a std::variant containing a std::variant work?


https://reviews.llvm.org/D51520