[Lldb-commits] [lldb] r341714 - [Disassembler] Run ARM-specific tests only if the ARM backend is built.

[Davide Italiano via lldb-commits]

On Fri, Sep 7, 2018 at 2:37 PM Davide Italiano via lldb-commits
<lldb-commits at lists.llvm.org> wrote:
>
> Author: davide
> Date: Fri Sep  7 14:36:21 2018
> New Revision: 341714
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341714&view=rev
> Log:
> [Disassembler] Run ARM-specific tests only if the ARM backend is built.
>
> <rdar://problem/44239070>
>
> Modified:
>     lldb/trunk/unittests/Disassembler/CMakeLists.txt
>
> Modified: lldb/trunk/unittests/Disassembler/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Disassembler/CMakeLists.txt?rev=341714&r1=341713&r2=341714&view=diff
> ==============================================================================
> --- lldb/trunk/unittests/Disassembler/CMakeLists.txt (original)
> +++ lldb/trunk/unittests/Disassembler/CMakeLists.txt Fri Sep  7 14:36:21 2018
> @@ -1,11 +1,13 @@
> -add_lldb_unittest(DisassemblerTests
> -  TestArmv7Disassembly.cpp
> -  LINK_LIBS
> -    lldbCore
> -    lldbSymbol
> -    lldbTarget
> -    lldbPluginDisassemblerLLVM
> -    lldbPluginProcessUtility
> -  LINK_COMPONENTS
> -    Support
> -    ${LLVM_TARGETS_TO_BUILD})
> +if("ARM" IN_LIST LLVM_TARGETS_TO_BUILD)
> +  add_lldb_unittest(DisassemblerTests
> +    TestArmv7Disassembly.cpp
> +    LINK_LIBS
> +      lldbCore
> +      lldbSymbol
> +      lldbTarget
> +      lldbPluginDisassemblerLLVM
> +      lldbPluginProcessUtility
> +    LINK_COMPONENTS
> +      Support
> +      ${LLVM_TARGETS_TO_BUILD})
> +endif()
>

Jason, I went ahead and committed this because it's breaking one of
our swift-lldb bots (as you know), but I would greatly appreciate a
post-commit review of this change (yay/nay from you) before I backport
this.

--
Davide