[Lldb-commits] [PATCH] D51445: Remove undefined behavior around the use of StateType

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

In https://reviews.llvm.org/D51445#1220905, @aprantl wrote:

> Thanks! I assume there is a whole bunch of other enums for which we should be doing the same thing now?
>  Also there might be some 1-based ones for which we also need to check the lower bound.


Be careful about enums in lldb-enumerations.h since they do make it into the SB API's.  I don't think the terminating element matters because Python doesn't actually know these are enums, it just thinks they are global variables, but you'd have to make sure you don't mess up other C++ clients.


https://reviews.llvm.org/D51445