[Lldb-commits] [PATCH] D51445: Remove undefined behavior around the use of StateType

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 30 17:01:12 PDT 2018


shafik marked 3 inline comments as done.
shafik added a comment.

@jingham I am switching to the @aprantl suggestions which feels cleaner and removes this issue.



================
Comment at: include/lldb/lldb-enumerations.h:60
                    ///< or threads get the chance to run.
+  kNumStateType
 };
----------------
aprantl wrote:
> I think we usually do something like eLastsState = eStateSuspended. This avoid having to add the case to all the switches.
This approach seems like a much better idiom, I will switch to that.


https://reviews.llvm.org/D51445





More information about the lldb-commits mailing list