[Lldb-commits] [lldb] r341121 - Move NoBuiltin=true closer to the other LangOpts code [NFC]
Raphael Isemann via lldb-commits
lldb-commits at lists.llvm.org
Thu Aug 30 13:56:58 PDT 2018
Author: teemperor
Date: Thu Aug 30 13:56:58 2018
New Revision: 341121
URL: http://llvm.org/viewvc/llvm-project?rev=341121&view=rev
Log:
Move NoBuiltin=true closer to the other LangOpts code [NFC]
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp?rev=341121&r1=341120&r2=341121&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp (original)
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Thu Aug 30 13:56:58 2018
@@ -455,6 +455,10 @@ ClangExpressionParser::ClangExpressionPa
false; // Debuggers get universal access
m_compiler->getLangOpts().DollarIdents =
true; // $ indicates a persistent variable name
+ // We enable all builtin functions beside the builtins from libc/libm (e.g.
+ // 'fopen'). Those libc functions are already correctly handled by LLDB, and
+ // additionally enabling them as expandable builtins is breaking Clang.
+ m_compiler->getLangOpts().NoBuiltin = true;
// Set CodeGen options
m_compiler->getCodeGenOpts().EmitDeclMetadata = true;
@@ -510,10 +514,6 @@ ClangExpressionParser::ClangExpressionPa
// 8. Most of this we get from the CompilerInstance, but we also want to give
// the context an ExternalASTSource.
- // We enable all builtin functions beside the builtins from libc/libm (e.g.
- // 'fopen'). Those libc functions are already correctly handled by LLDB, and
- // additionally enabling them as expandable builtins is breaking Clang.
- m_compiler->getLangOpts().NoBuiltin = true;
auto &PP = m_compiler->getPreprocessor();
auto &builtin_context = PP.getBuiltinInfo();
More information about the lldb-commits
mailing list