[Lldb-commits] [lldb] r341105 - Fixed code style for the CodeCompletion members [NFC]

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 30 12:47:53 PDT 2018


Author: teemperor
Date: Thu Aug 30 12:47:53 2018
New Revision: 341105

URL: http://llvm.org/viewvc/llvm-project?rev=341105&view=rev
Log:
Fixed code style for the CodeCompletion members [NFC]

This code is in LLDB, so it should also follow the LLDB code style
and use the m_ prefix for members.

Modified:
    lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp?rev=341105&r1=341104&r2=341105&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp (original)
+++ lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Thu Aug 30 12:47:53 2018
@@ -558,11 +558,11 @@ namespace {
 /// of an incomplete `expr` invocation.
 //----------------------------------------------------------------------
 class CodeComplete : public CodeCompleteConsumer {
-  CodeCompletionTUInfo CCTUInfo;
+  CodeCompletionTUInfo m_info;
 
-  std::string expr;
-  unsigned position = 0;
-  StringList &matches;
+  std::string m_expr;
+  unsigned m_position = 0;
+  StringList &m_matches;
 
   /// Returns true if the given character can be used in an identifier.
   /// This also returns true for numbers because for completion we usually
@@ -639,8 +639,8 @@ public:
   ///
   CodeComplete(StringList &matches, std::string expr, unsigned position)
       : CodeCompleteConsumer(CodeCompleteOptions(), false),
-        CCTUInfo(std::make_shared<GlobalCodeCompletionAllocator>()), expr(expr),
-        position(position), matches(matches) {}
+        m_info(std::make_shared<GlobalCodeCompletionAllocator>()), m_expr(expr),
+        m_position(position), m_matches(matches) {}
 
   /// Deregisters and destroys this code-completion consumer.
   virtual ~CodeComplete() {}
@@ -734,8 +734,8 @@ public:
         // Merge the suggested Token into the existing command line to comply
         // with the kind of result the lldb API expects.
         std::string CompletionSuggestion =
-            mergeCompletion(expr, position, ToInsert);
-        matches.AppendString(CompletionSuggestion);
+            mergeCompletion(m_expr, m_position, ToInsert);
+        m_matches.AppendString(CompletionSuggestion);
       }
     }
   }
@@ -756,10 +756,10 @@ public:
   }
 
   CodeCompletionAllocator &getAllocator() override {
-    return CCTUInfo.getAllocator();
+    return m_info.getAllocator();
   }
 
-  CodeCompletionTUInfo &getCodeCompletionTUInfo() override { return CCTUInfo; }
+  CodeCompletionTUInfo &getCodeCompletionTUInfo() override { return m_info; }
 };
 } // namespace
 




More information about the lldb-commits mailing list