[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

[Frederic Riss via Phabricator via lldb-commits]

friss added inline comments.


================
Comment at: source/Symbol/ClangASTContext.cpp:7664
+
+  assert(args.size() &&
+         "We shouldn't have a template specialization without any args");
----------------
friss wrote:
> shafik wrote:
> > The asset before we do math making this assumption i.e. `args.size() - 1`
> The assert is also wrong because of the empty pack issue. I'll update the patch.
Actually, this is not true. The Decl will always have at least one argument which is the pack. The pack can be empty, but the Decl still records it as one argument. The assert should be hoisted though.


https://reviews.llvm.org/D51387