[Lldb-commits] [PATCH] D51461: Support setting a breakpoint by FileSpec+Line+Column in the SBAPI.

[Adrian Prantl via Phabricator via lldb-commits]

aprantl updated this revision to Diff 163231.
aprantl marked 4 inline comments as done.
aprantl added a comment.

Address review feedback.


https://reviews.llvm.org/D51461

Files:
  include/lldb/API/SBTarget.h
  include/lldb/Breakpoint/BreakpointResolver.h
  include/lldb/Breakpoint/BreakpointResolverFileLine.h
  include/lldb/Target/Target.h
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_by_line_and_column/Makefile
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_by_line_and_column/main.c
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/serialize/TestBreakpointSerialization.py
  packages/Python/lldbsuite/test/lldbutil.py
  scripts/interface/SBTarget.i
  source/API/SBTarget.cpp
  source/Breakpoint/BreakpointResolver.cpp
  source/Breakpoint/BreakpointResolverFileLine.cpp
  source/Commands/CommandObjectBreakpoint.cpp
  source/Core/IOHandler.cpp
  source/Symbol/LineEntry.cpp
  source/Target/Target.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51461.163231.patch
Type: text/x-patch
Size: 27199 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180829/9613536b/attachment-0001.bin>