[Lldb-commits] [PATCH] D51442: Don't include the Age in the UUID for CvRecordPdb70 UUID records in minidump files

[Leonard Mosescu via Phabricator via lldb-commits]

lemo accepted this revision.
lemo added a comment.
This revision is now accepted and ready to land.

Looks good (with one inline request for a comment)



================
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:85
+      auto arch = GetArchitecture();
+      if (arch.GetTriple().getVendor() == llvm::Triple::Apple)
+        return UUID::fromData(pdb70_uuid->Uuid, sizeof(pdb70_uuid->Uuid));
----------------
please add a comment describing the situation (breakpad producing debug ids which don't match the binaries)


https://reviews.llvm.org/D51442