[Lldb-commits] [PATCH] D50751: Allow use of self.filecheck in LLDB tests (c.f self.expect)

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:194
+        # of the test build dir is the LLVM build dir.
+        llvm_build_dir = os.path.dirname(os.path.abspath(test_build_dir))
+    assert os.path.lexists(llvm_build_dir)
----------------
teemperor wrote:
> This is true if we build LLDB as part of LLVM, but this doesn't seem correct if LLDB is built against an existing LLVM (which is in general supported in LLDB's CMake if IIUC). I think the best way is to pass the binary directory for this to dotest and configure it in the lit.cfg.
Rather than making the change here, as @teemperor pointed out, you should use the existing mechanisms we have in the CMake files. Look for LLDB_DEFAULT_TEST_DSYMUTIL to see how we handle this (and the extension too!) for dsymutil.




https://reviews.llvm.org/D50751