[Lldb-commits] [lldb] r339959 - Remove outdated TODOs in RegisterValue

[Alex Langford via lldb-commits]

Author: xiaobai
Date: Thu Aug 16 15:48:46 2018
New Revision: 339959

URL: http://llvm.org/viewvc/llvm-project?rev=339959&view=rev
Log:
Remove outdated TODOs in RegisterValue

These TODOs were for setting m_type in RegisterValue::SetValueFromString
in the case where reg_info's encoding was eEncodingUint or
eEncodingSint. m_type is set by SetUInt{8,16,32,64.128} during the
SetUInt call.

Modified:
    lldb/trunk/source/Utility/RegisterValue.cpp

Modified: lldb/trunk/source/Utility/RegisterValue.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/RegisterValue.cpp?rev=339959&r1=339958&r2=339959&view=diff
==============================================================================
--- lldb/trunk/source/Utility/RegisterValue.cpp (original)
+++ lldb/trunk/source/Utility/RegisterValue.cpp Thu Aug 16 15:48:46 2018
@@ -380,7 +380,6 @@ Status RegisterValue::SetValueFromString
           "unsupported unsigned integer byte size: %u", byte_size);
       break;
     }
-    // TODO: Shouldn't we be setting m_type here?
     break;
 
   case eEncodingSint:
@@ -410,8 +409,6 @@ Status RegisterValue::SetValueFromString
                                      byte_size);
       break;
     }
-
-    // TODO: Shouldn't we be setting m_type here?
     break;
 
   case eEncodingIEEE754: {