[Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

[Greg Clayton via Phabricator via lldb-commits]

clayborg marked 2 inline comments as done.
clayborg added inline comments.


================
Comment at: tools/lldb-vscode/lldb-vscode.cpp:2646
+        g_vsc.out = fdopen(socket_fd, "w");
+        if (g_vsc.in == nullptr || g_vsc.out == nullptr) {
+          if (g_vsc.log)
----------------
The mutex isn't the problem, it is being able to read and write from the in and out streams. So adding a mutex to VSCode won't help. We have very simple interactions with in and out where we read lines and read a specific amount of data, and we just write data out.


https://reviews.llvm.org/D50365