[Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

[Greg Clayton via lldb-commits]

Inline comments really help if you don't mind.

> On Aug 16, 2018, at 9:23 AM, Zachary Turner via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> zturner added a comment.
> 
> I had a couple of other comments, but since I responded from email since I was on the go and I guess they didn't show up inline.  Sorry about that.  If you prefer I can resubmit them all as inline comments, or I guess you can just respond to the email thread.
> 
> 
> 
> ================
> Comment at: tools/lldb-vscode/JSONUtils.cpp:472
> +    char path[PATH_MAX] = "";
> +    file.GetPath(path, sizeof(path));
> +    if (path[0]) {
> ----------------
> clayborg wrote:
>> This is a SBFileSpec. We don't allow any STL to be used in API.
> Ahh good point, my bad.
> 
> 
> https://reviews.llvm.org/D50365
> 
> 
>