[Lldb-commits] [PATCH] D50383: Move SafeMachO from Utility to Host

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: jingham, zturner, teemperor.
Herald added a subscriber: fedor.sergeev.

One of the conclusions of the discussion on https://reviews.llvm.org/D49740 was that SafeMachO is better
off in the Host module (as that's the only place which should include
mach/machine.h, which is what this header is working around). Also, Utility,
which is the only module which cannot include Host, should not be doing
anything with object file formats.

This patch implements that move, and also removes any unneded includes of that
file.

I've verified that MacOS still compiles after this.


https://reviews.llvm.org/D50383

Files:
  include/lldb/Host/SafeMachO.h
  include/lldb/Utility/SafeMachO.h
  source/Host/common/Symbols.cpp
  source/Host/macosx/Symbols.cpp
  source/Host/macosx/objcxx/HostInfoMacOSX.mm
  source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.h
  source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.h
  source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h
  source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h
  source/Plugins/ObjectContainer/Universal-Mach-O/ObjectContainerUniversalMachO.h
  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h
  source/Plugins/Process/MacOSX-Kernel/ThreadKDP.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
  source/Plugins/Process/mach-core/ProcessMachCore.cpp
  source/Plugins/Process/mach-core/ThreadMachCore.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50383.159492.patch
Type: text/x-patch
Size: 11471 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180807/1e31fe41/attachment.bin>