[Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

[Zachary Turner via lldb-commits]

Did you see my comments on the first round about how the CMake build didn’t
work? Because I don’t see any changes to CMakeLists.txt here, which means
it still won’t work.

The easiest way to make sure you get all the fixes that may have gone in
after your initial commit is to revert the revert and build your
modifications on top of that. Then, for example, the fixes to
CMakeLists.txt would already be here.
On Mon, Aug 6, 2018 at 11:14 AM Greg Clayton via Phabricator <
reviews at reviews.llvm.org> wrote:

> clayborg created this revision.
> clayborg added reviewers: labath, zturner, markmentovai, javed.absar.
> Herald added subscribers: chrib, kristof.beyls.
>
> In this patch I add support for ARM and ARM64 break pad files. There are
> two flavors of ARM: Apple where FP is
> https://reviews.llvm.org/source/openmp/, and non Apple where FP is
> https://reviews.llvm.org/source/libunwind/. Added minimal tests that load
> up ARM64 and the two flavors or ARM core files with a single thread and
> known register values in each register. Each register is checked for the
> exact value.
>
> This is a fixed version of: https://reviews.llvm.org/D49750
>
> The changes from https://reviews.llvm.org/D49750 are:
>
> - Don't init the m_arch in the Initialize call as a system info isn't
> required. This keeps the thread list, module list and other tests from
> failing
> - Added -Wextended-offsetof to Xcode project so we catch use extended
> usages of offsetof before submission
> - Fixed any extended offset of warnings
>
>
> https://reviews.llvm.org/D50336
>
> Files:
>   include/lldb/Target/Target.h
>   lldb.xcodeproj/project.pbxproj
>
> packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
>
> packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/arm-linux.dmp
>
> packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/arm-macos.dmp
>
> packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/arm64-macos.dmp
>   source/Plugins/Process/minidump/MinidumpParser.cpp
>   source/Plugins/Process/minidump/MinidumpParser.h
>   source/Plugins/Process/minidump/ProcessMinidump.cpp
>   source/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp
>   source/Plugins/Process/minidump/RegisterContextMinidump_ARM.h
>   source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp
>   source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.h
>   source/Plugins/Process/minidump/ThreadMinidump.cpp
>   source/Target/Target.cpp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180806/4f041419/attachment.html>