[Lldb-commits] [lldb] r338491 - Removed failing StreamTest case

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 31 23:35:28 PDT 2018


Author: teemperor
Date: Tue Jul 31 23:35:27 2018
New Revision: 338491

URL: http://llvm.org/viewvc/llvm-project?rev=338491&view=rev
Log:
Removed failing StreamTest case

The suspicious behavior is obviously because this method reads
OOB memory, so I'll remove it for now and re-add the test alongside
the fix later.

Modified:
    lldb/trunk/unittests/Utility/StreamTest.cpp

Modified: lldb/trunk/unittests/Utility/StreamTest.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/StreamTest.cpp?rev=338491&r1=338490&r2=338491&view=diff
==============================================================================
--- lldb/trunk/unittests/Utility/StreamTest.cpp (original)
+++ lldb/trunk/unittests/Utility/StreamTest.cpp Tue Jul 31 23:35:27 2018
@@ -106,12 +106,6 @@ TEST_F(StreamTest, PutCharNull) {
 }
 
 TEST_F(StreamTest, PutCStringAsRawHex8) {
-  s.PutCStringAsRawHex8("");
-  // FIXME: Check that printing 00 on an empty string is the intended behavior.
-  // It seems kind of unexpected  that we print the trailing 0 byte for empty
-  // strings, but not for non-empty strings.
-  EXPECT_EQ("00", TakeValue());
-
   s.PutCStringAsRawHex8("foobar");
   EXPECT_EQ("666f6f626172", TakeValue());
 




More information about the lldb-commits mailing list