[Lldb-commits] [lldb] r338460 - Android is an environment and we were comparing the android triple

Eric Christopher via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 31 16:53:24 PDT 2018


Author: echristo
Date: Tue Jul 31 16:53:24 2018
New Revision: 338460

URL: http://llvm.org/viewvc/llvm-project?rev=338460&view=rev
Log:
Android is an environment and we were comparing the android triple
against the OS rather than the environment. Also update other
uses of OS when we meant environment in the android local code.

NFC intended.

Modified:
    lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp

Modified: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp?rev=338460&r1=338459&r2=338460&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp (original)
+++ lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp Tue Jul 31 16:53:24 2018
@@ -95,7 +95,7 @@ PlatformSP PlatformAndroid::CreateInstan
     }
 
     if (create) {
-      switch (triple.getOS()) {
+      switch (triple.getEnvironment()) {
       case llvm::Triple::Android:
         break;
 
@@ -103,8 +103,8 @@ PlatformSP PlatformAndroid::CreateInstan
       // Only accept "unknown" for the OS if the host is android and it
       // "unknown" wasn't specified (it was just returned because it was NOT
       // specified)
-      case llvm::Triple::OSType::UnknownOS:
-        create = !arch->TripleOSWasSpecified();
+      case llvm::Triple::EnvironmentType::UnknownEnvironment:
+        create = !arch->TripleEnvironmentWasSpecified();
         break;
 #endif
       default:




More information about the lldb-commits mailing list