[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

Alexander Polyakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 31 12:42:54 PDT 2018

apolyakov added inline comments.

Comment at: source/API/SBTarget.cpp:1467
+  }
+  const ConstString csFrom(from), csTo(to);
+  if (csFrom && csTo) {
aprantl wrote:
> personally I would write this as:
> ```
> if (!csFrom)
>   return error.SetErrorString("<from> path is empty");
> if (!csTo)
>   return error.SetErrorString("<to> path is empty");
> Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_API));
> if (log)
>   log->Printf("SBTarget(%p)::%s: '%s' -> '%s'",
>               static_cast<void *>(target_sp.get()),  __FUNCTION__,
>               from, to);
> target_sp->GetImageSearchPathList().Append(csFrom, csTo, true);
> ```
in my opinion, the branch `if (csFrom && csTo)` will be executed in most cases, so it is reasonable to make it executed first, as this will benefit the branch prediction of the processor. Is this a worthwhile argument?


More information about the lldb-commits mailing list